[buddypress-trac] [BuddyPress Trac] #5817: Additional styling support for BuddyPress Widgets

[buddypress-trac]

#5817: Additional styling support for BuddyPress Widgets
-----------------------------------------+------------------
 Reporter:  mercime                      |       Owner:
     Type:  enhancement                  |      Status:  new
 Priority:  normal                       |   Milestone:  2.4
Component:  Appearance - Template Parts  |     Version:  1.7
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch                    |
-----------------------------------------+------------------
Changes (by r-a-y):

 * version:   => 1.7
 * type:  defect (bug) => enhancement


Comment:

 mercime - Thanks for the rundown about how Theme Check does not look for
 dynamic CSS classes.

 It may be a good issue to raise here:
 https://github.com/Otto42/theme-check

 As for widget CSS class injection, I've tweaked your `5817-4b.diff` patch
 and made it so it only adds the `'widget'` and `'buddypress'` CSS classes
 if they do not exist.

 I tested this on the Grisaille theme and it works.

 Note: I haven't altered any of our current widgets in the patch because we
 haven't done anything to them since v1.7 and they still work ;)

 Yes, I'm aware that for the twenty-* themes, that the `'widget'` class is
 duplicated due to the `classname`:
 https://github.com/WordPress/WordPress/blob/master/wp-
 content/themes/twentyfifteen/functions.php#L136
 https://buddypress.trac.wordpress.org/browser/tags/2.3.2/src/bp-members
 /bp-members-widgets.php?marks=44,257,407#L41

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5817#comment:25>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac