[buddypress-trac] [BuddyPress Trac] #5817: Additional styling support for BuddyPress Widgets

[buddypress-trac]

#5817: Additional styling support for BuddyPress Widgets
-----------------------------------------+------------------
 Reporter:  mercime                      |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  2.4
Component:  Appearance - Template Parts  |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch                    |
-----------------------------------------+------------------

Comment (by mercime):

 It is evident that we do need to inject the `widget` and `buddypress`
 classes in `before_widget` to provide the styling support we provide in
 `buddypress.css` for our widgets because we cannot rely on themes to
 provide the necessary elements to inject the classes for the following
 reasons:

 1. It is not even a requirement in the WordPress Theme Review process to
 add the class element and the variable in `before_widget`, i.e., a theme
 can be approved even without those elements. The
 [http://plugins.svn.wordpress.org/theme-
 check/tags/20141222.1/checks/widgets.php WP.org Theme Check on widgets]
 used in the theme submission process doesn't check for said elements.

 2. Since Matt
 [https://wordpress.slack.com/archives/themereview/p1432860396003236 joined
 in the theme review slack channel], the theme review team has already
 started researching for the best way for a separate upload process for
 theme authors to get their themes in the WP theme repository
 [https://make.wordpress.org/themes/2015/05/29/proposal-curated-theme-
 directory/ without needing to go through a full review by a WP theme
 reviewer]. That separate process will use the Theme Check plugin, probably
 beefed up a little but doubtful if it will check for the elements we need.

 3. Just to note that, while not directly related to this discussion, even
 the [https://github.com/Automattic/vip-scanner/blob/master/tests/checks
 /test-WidgetsCheck.php WP.com VIP Scanner on widgets] does not check for
 the `before_widget` items at all, only the `register_sidebar` location ID.

 So at this point in addition to  5817-4b.diff posted above, I suggest
 removing `buddypress widget` from the calls to `WP_Widget constructor` in
 respective components to remove duplication of classes. Advice on how to
 proceed with this ticket would be great.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5817#comment:24>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac