[buddypress-trac] [BuddyPress Trac] #6095: Define behavior for group status

[buddypress-trac]

#6095: Define behavior for group status
------------------------------------+------------------------------
 Reporter:  tandreatta              |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Groups                  |     Version:  2.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------------

Comment (by tandreatta):

 Replying to [comment:5 boonebgorges]:
 > My personal preference is to use the `bp_groups` prefix
 Mine too. But almost all functions in the bp-groups use just `groups` ...
 In patch v2 boolean function names are
 `groups_is_[private|hidden]_group_status()`.
 I think that function should be use only internally - in next release I
 hope we will implement methods in `BP_Groups_Group` like
 `$group->is_content_private()`, `$group->is_hidden_in_directory()`,
 `$group->is_membership_request_allowed()`, etc..

 > We should add a function for fetching all valid group statuses
 In v2 I defined `groups_get_valid_status()` and
 `groups_get_allowed_status()`.

 > Running status names through ucfirst() will not work as a general
 solution.
 But it works for defaults (public, private, hidden). And there are
 filters. And there is translation support.

 > This points to the need for a more robust method of registering custom
 group types.
 But that method must allow translation.

 > Related: stuff like `BP_Groups_Component::valid_creation_status` etc
 seems too ad hoc. If group types were stored in proper group type objects,
 then the objects themselves could have properties [...]
 I would prefer to have properties/methods in `BP_Groups_Group` instead.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6095#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac