[buddypress-trac] [BuddyPress Trac] #6095: Define behavior for group status

[buddypress-trac]

#6095: Define behavior for group status
------------------------------------+------------------------------
 Reporter:  tandreatta              |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Groups                  |     Version:  2.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------------

Comment (by boonebgorges):

 This is really excellent - thanks for yor work so far, tandreatta. We can
 get started on implementing much of this right away after 2.2 comes out.

 A few comments:

 - I'd like to tweak function names in some places. My personal preference
 is to use the `bp_groups` prefix, despite the fact that many of our
 existing functions use just `groups`. And there are some functions that
 return boolean - like `groups_private_group()` - that should probably have
 a verb somewhere, like `bp_groups_is_private_group()`. (Maybe a bad
 example, because it seems odd to have the word 'private' in the function
 name - we should figure out a more proper descriptive name here.)
 - We should add a function for fetching all valid group statuses, instead
 of reaching directly into `$bp->groups->valid_status`.
 - Running status names through `ucfirst()` will not work as a general
 solution. This points to the need for a more robust method of registering
 custom group types. See #6006 for the member type API, and see #6094 for a
 closely related discussion.
 - Related: stuff like `BP_Groups_Component::valid_creation_status` etc
 seems too ad hoc. If group types were stored in proper group type objects,
 then the objects themselves could have properties like 'show_in_creation'
 or 'requires_membership_moderation' or whatever. See
 https://buddypress.trac.wordpress.org/ticket/6094#comment:3

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6095#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac