[buddypress-trac] [BuddyPress Trac] #6119: Imports cause PHP Warnings in bp_blogs_format_activity_action_new_blog_post
buddypress-trac
noreply at wordpress.org
Fri Jan 16 08:17:55 UTC 2015
#6119: Imports cause PHP Warnings in bp_blogs_format_activity_action_new_blog_post
--------------------------+------------------
Reporter: DJPaul | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.2
Component: Blogs | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Comment (by imath):
I haven't forgotten this part of our chat. And it's actually the case. If
you test the patch you'll see that :
if i publish a post without a title, no notice
if i update a post having a title by removing the title, the activity
action will be updated to inform the post has no title. This part is
managed thanks to this function `bp_blogs_update_post_activity_meta()`
line 467 to 468
You should check
https://wordpress.slack.com/archives/buddypress/p1421267970000197 to
understand why i've kept
{{{
// If activity already exists try to get the post title from activity meta
} else if ( ! empty( $activity->id ) ) {
$post_title = bp_activity_get_meta( $activity->id, 'post_title' );
}}}
So in 6119.03.patch i've added a unit test to cover that possibility, but
you'll see it will fail, that's because of #6127. You'll need to apply the
patch i've added to 6127 to see test is not failing.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6119#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list