[buddypress-trac] [BuddyPress Trac] #6119: Imports cause PHP Warnings in bp_blogs_format_activity_action_new_blog_post
buddypress-trac
noreply at wordpress.org
Fri Jan 16 00:14:16 UTC 2015
#6119: Imports cause PHP Warnings in bp_blogs_format_activity_action_new_blog_post
--------------------------+------------------
Reporter: DJPaul | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.2
Component: Blogs | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Comment (by DJPaul):
Thanks for your work on this ticket, imath. I think the comments help a
lot to make the code more understandable.
I am reluctant to make this comment again given your hard work, but... :)
I thought we decided when we spoke with Boone the other day that we did
not need the following clause added:
{{{
// If activity already exists try to get the post title from activity meta
} else if ( ! empty( $activity->id ) ) {
$post_title = bp_activity_get_meta( $activity->id, 'post_title' );
}}}
Chat link is
https://wordpress.slack.com/archives/buddypress/p1421267309000163 Boone's
reply is a few lines down:
If someone wants to update a post so that it has no title, we should
respect that
Other than this last small point, the patch looks great.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6119#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list