[buddypress-trac] [BuddyPress Trac] #5509: invites-loop template re-factoring

buddypress-trac noreply at wordpress.org
Thu Jan 8 11:45:11 UTC 2015


#5509: invites-loop template re-factoring
-------------------------------------+------------------
 Reporter:  hnla                     |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  low                      |   Milestone:  2.2
Component:  Theme / Template Parts   |     Version:
 Severity:  minor                    |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Comment (by hnla):

 @dcavins Thanks for looking over.

 >BP uses a combination of #message.info for other notices, so I think we
 could use that same structure here for the "no friends" error message and
 save a new style for themers to catch. Like:

 My only reasoning here was to introduce a more generic container block to
 agregate messages, but not to fussed on this point so lets roll without.

 Fine with message string changes.

 Headings are an issue, I have in fact recently run through the BP styles
 to re-factor many font-size properties to use keywords as em/% units can
 have consequences in unknown layouts, so my earlier use of percentage
 units here might need reviewing.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5509#comment:17>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list