[buddypress-trac] [BuddyPress Trac] #5509: invites-loop template re-factoring

[buddypress-trac]

#5509: invites-loop template re-factoring
-------------------------------------+------------------
 Reporter:  hnla                     |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  low                      |   Milestone:  2.2
Component:  Theme / Template Parts   |     Version:
 Severity:  minor                    |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Comment (by dcavins):

 I'm a fan of helpful error messages and enough text so that inexperienced
 users aren't totally lost.

 Some thoughts:
 * BP uses a combination of #message.info for other notices, so I think we
 could use that same structure here for the "no friends" error message and
 save a new style for themers to catch. Like:
 {{{
 <div id="message" class="info">
          <p>Sorry, no members were found.</p>
 </div>
 }}}

 * The logic to test for no friends has to come before "do I have non-
 member friends to invite" because having no friends means you also have no
 non-member friends to invite.

 * Appearance - Hmm, the new header font sizing is a bit of a mixed bag.
 See attached screenshots. Short of sniffing the theme used, I think hnla's
 done pretty well here.

 * Text - I've simplified the strings to these:
  * pane header: "Manage your group invitations"
  * atop the invite list: "Your current invitations"
  * no friends selected: "Select friends to invite."
  * no eligible friends to choose from: "All of your friends already belong
 to this group."
  * no friends at all: "Group invitations can only be extended to friends.
 Once you've made some friendships, you'll be able to invite those members
 to this group."

 I've added a new patch that adds my opinions. Thanks for working on this
 hnla.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5509#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac