[buddypress-trac] [BuddyPress Trac] #6431: get_group_extras function doesn't "respects" the user_id variable from groups_get_groups() function

[buddypress-trac]

#6431: get_group_extras function doesn't "respects" the user_id variable from
groups_get_groups() function
--------------------------------------------+------------------
 Reporter:  lenasterg                       |       Owner:
     Type:  defect (bug)                    |      Status:  new
 Priority:  normal                          |   Milestone:  2.5
Component:  Component - Groups              |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch early has-unit-tests  |
--------------------------------------------+------------------

Comment (by DJPaul):

 Not tested yet, but quick comments for you @Mamaduka:

 * You remove `AND is_banned = 0` from the query. Is this to do with
 removing that second query by that `is_banned` check you added? If so,
 nice.
 * In the `Mock defaults values for extras` lines where you moved those
 variable declarations outside the `for` loop -- are you sure? Aren't those
 inside so they are reset for each group in the query? Not just reset if
 `is_banned`?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6431#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac