[buddypress-trac] [BuddyPress Trac] #6290: Avatars, an extensible UI

buddypress-trac noreply at wordpress.org
Fri Apr 24 09:02:22 UTC 2015


#6290: Avatars, an extensible UI
------------------------------------+-----------------------
 Reporter:  imath                   |       Owner:  imath
     Type:  idea                    |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.3
Component:  API - Avatars           |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+-----------------------

Comment (by imath):

 Replying to [comment:70 hnla]:

 Thanks hnla for your great work so far. My feeling as i told you in
 private is : i'm afraid people won't understand if we are displaying the
 two elements the one under the other despite the fact there's enough width
 available to display them side by side.

 I like how the UI is shapping for all other aspects, so i suggest we fix
 this litte annoying thing directly in javascript.

 In avatar.js i get the width (0 to 450) of the avatar to crop (ac.w), the
 width of the parent (p.w), and the full width avatar constant (full.w), so
 i'm simply checking :
 `ac.w + full.w + 20 < p.w` 20 is a margin i keep.

 If we are in this case, i'm adding a specific class so that the layout is
 using all the available width, else the preview is going under.

 So 6290.layout.01.patch is 6290.css.04 + 6290.tpl.01 + js workaround

 I agree it's not the best way of dealing with this, but i think we need to
 have this to carry on and improve this in future releases.

 > I want to address the avatar menu styling, proposing that we copy what I
 did in the twentyfifteen companion styles for them  - 'tabbed view style'
 -to either avatar.css or bp main styles, however would/does that tab style
 suit any theme generically, as it is somewhat a design element?

 That would be terrific !! I really like the tab view you are using in
 twentytwelve. I think this should go in avatar.css

 I you're ok, i'll update the test drive so that we can test on many
 browsers/OS.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6290#comment:71>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list