[buddypress-trac] [BuddyPress Trac] #6306: custom post type support for activities

[buddypress-trac]

#6306: custom post type support for activities
-----------------------------------+----------------------------------
 Reporter:  shanebp                |       Owner:
     Type:  defect (bug)           |      Status:  reopened
 Priority:  normal                 |   Milestone:  Under Consideration
Component:  Component - Blogs      |     Version:  2.2
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+----------------------------------

Comment (by imath):

 So 6306.patch will pass all tests except the
 `test_bp_activity_post_types_filtering_blogs_comments` one. 6306.alt.patch
 will pass all tests.

 `test_bp_activity_post_types_filtering_blogs_comments` is testing the case
 where :
 - Post type is registering using the 'buddypress-activity' support
 - It filters 'bp_blogs_record_comment_post_type' to track the comments


 I agree 6306.patch is the more consistent option. But means if you need to
 generate activity for the comments about your post types, do not use
 'buddypress-activity' support but use a deprecated filter instead (a bit
 annoying).

 6306.alt.patch means you can use 'buddypress-activity' support when
 registering your post type, but as soon you will filter
 'bp_blogs_record_comment_post_type' to track comments about it, all
 activity tracking args will be the one of the 'Post' post types (a bit
 annoying also!).

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6306#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac