[buddypress-trac] [BuddyPress Trac] #6306: custom post type support for activities

[buddypress-trac]

#6306: custom post type support for activities
-----------------------------------+----------------------------------
 Reporter:  shanebp                |       Owner:
     Type:  defect (bug)           |      Status:  reopened
 Priority:  normal                 |   Milestone:  Under Consideration
Component:  Component - Blogs      |     Version:  2.2
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+----------------------------------

Comment (by imath):

 Replying to [comment:14 boonebgorges]:
 > (but maybe make a note in the documentation that it's deprecated).

 I'd follow your recommandation on option 1, but this last parenthese is
 introducing some hesitations :)
 I agree that the filter 'bp_blogs_record_post_post_types' should be
 deprecated. But as we haven't worked on the comments about post types, the
 other filter 'bp_blogs_record_comment_post_type' can't be deprecated yet.

 In bp-blogs-loader.php there's already a backward compability mechanism in
 place :
 https://buddypress.trac.wordpress.org/browser/trunk/src/bp-blogs/bp-blogs-
 loader.php#L94

 This filter should have been deprecated. Plugins using this filter are not
 a problem, default post types activity parameters are generated, there are
 new dropdown filters for the post type and by default the component is
 activity.

 The real problem appears when they filter
 'bp_blogs_record_comment_post_type', as the activity/comment
 synchronization is forcing the activity type to be 'new_blog_post' :
 see https://buddypress.trac.wordpress.org/browser/trunk/src/bp-blogs/bp-
 blogs-activity.php#L530

 I'll need to run some other tests, because i'm wondering what would happen
 if a plugin was using activity post types introduced in 2.2 and filter
 'bp_blogs_record_comment_post_type'. In this case option 2 might make sure
 if the blogs component is active to filter the tracking args so that
 comment are synced with activities for the particular post type. But for
 sure option 1 wouldn't.

 But i might overthink about it :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6306#comment:17>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac