[buddypress-trac] [BuddyPress Trac] #5855: RTL support for @atme mention auto-suggestions
buddypress-trac
noreply at wordpress.org
Sat Sep 6 04:01:16 UTC 2014
#5855: RTL support for @atme mention auto-suggestions
---------------------------+------------------
Reporter: netweb | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.1
Component: Notifications | Version:
Severity: normal | Resolution:
Keywords: |
---------------------------+------------------
Comment (by netweb):
Replying to [comment:2 DJPaul]:
> When I tested this previously, I noticed bad CSS issues, but I think I
know why it might not be finding the same user results. In
https://buddypress.trac.wordpress.org/browser/trunk/src/bp-core/bp-core-
classes.php#L2672 I made the assumption that a username in RTL would
effectively be "reversed" in the database compared to what we expect in a
LTR language (e..g. stored as "lauP" instead of "Paul"), so the
`search_wildcard` position is flipped around.
I was making all kinds of 'guesses' as to how all the logic in this works
also, I'm quite sure mine is entirely flawed :P
Here goes, it is RTL, which relates to reading and writing, or display in
our case, but the order is still the same for this use case, If I want to
mention `Paul`, I type `P`, `a`, `u`, `l`, and I do exactly the same for
`lauP`, `P` is the first letter reading from right to left, `a` is the
second, `u` the third and lastly `l`.
> I guess I should have done research to check if that quick assumption
was accurate or not; let's find a RTL user and ask them. :) It is easy to
change if the assumption was faulty, though the CSS fixes will require
much more effort.
Indeed, this is really the only way to know for certain ;)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5855#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list