[buddypress-trac] [BuddyPress Trac] #5855: RTL support for @atme mention auto-suggestions

[buddypress-trac]

#5855: RTL support for @atme mention auto-suggestions
---------------------------+------------------
 Reporter:  netweb         |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  2.1
Component:  Notifications  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:                 |
---------------------------+------------------
Changes (by DJPaul):

 * milestone:  Awaiting Review => 2.1


Comment:

 Thank you for testing this. I knew there were RTL issues in the @mentions
 changes prior to beta 1 but I also wanted to use it to see how many
 testers we have that use RTL; unfortunately, very few, it seems.

 It looks like @yoavf has worked on the RTL Tester plugin, I'm happy to
 assume that it works correctly.

 When I tested this previously, I noticed bad CSS issues, but I think I
 know why it might not be finding the same user results. In
 https://buddypress.trac.wordpress.org/browser/trunk/src/bp-core/bp-core-
 classes.php#L2672 I made the assumption that a username in RTL would
 effectively be "reversed" in the database compared to what we expect in a
 LTR language (e..g. stored as "lauP" instead of "Paul"), so the
 `search_wildcard` position is flipped around.

 I guess I should have done research to check if that quick assumption was
 accurate or not; let's find a RTL user and ask them. :) It is easy to
 change if the assumption was faulty, though the CSS fixes will require
 much more effort.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5855#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac