[buddypress-trac] [BuddyPress Trac] #5919: Xprofile field meta values not deleted with field

[buddypress-trac]

#5919: Xprofile field meta values not deleted with field
----------------------------------------+-----------------------------
 Reporter:  tometzky                    |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  low                         |   Milestone:  Future Release
Component:  XProfile                    |     Version:  2.1
 Severity:  minor                       |  Resolution:
 Keywords:  needs-patch good-first-bug  |
----------------------------------------+-----------------------------

Comment (by boonebgorges):

 > They're blindly replacing substrings in SQL query. This is
 thedailywtf.com inspired coding.

 These are highly targeted substring replacements that are covered by
 extensive unit tests. The BP team has a close connection to the WP core
 team (I am a member of both) and will be aware of breaking changes. In any
 case, these filters have nothing to do with the case at hand, so perhaps
 we could set aside your distaste for the purposes of this ticket :)

 >  Then it breaks when there's no meta defined.

 Can you give more details about what breaks? Are you getting some sort of
 error? Here is the relevant unit test:
 https://buddypress.trac.wordpress.org/browser/tags/2.1/tests/phpunit/testcases/xprofile/functions.php#L243

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5919#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac