[buddypress-trac] [BuddyPress Trac] #5919: Xprofile field meta values not deleted with field

[buddypress-trac]

#5919: Xprofile field meta values not deleted with field
----------------------------------------+-----------------------------
 Reporter:  tometzky                    |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  low                         |   Milestone:  Future Release
Component:  XProfile                    |     Version:  2.1
 Severity:  minor                       |  Resolution:
 Keywords:  needs-patch good-first-bug  |
----------------------------------------+-----------------------------

Comment (by tometzky):

 Yeah - it should be easy... But.

 1.

 When I added in `BP_XProfile_Field::delete()`:

 {{{
 if ( !bp_xprofile_delete_meta( $this->id, 'field' ) ) return false;
 }}}

 Then it breaks when there's no meta defined.

 2.

 Then I tried to check if any metadata exists. And then I went on to read
 bp_xprofile_filter_meta_query() and bp_filter_metaid_column_name()
 functions. And I cried. They're blindly replacing substrings in SQL query.
 This is [http://thedailywtf.com/ thedailywtf.com] inspired coding.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5919#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac