[buddypress-trac] [BuddyPress Trac] #5513: Bulk Notifications Management
noreply at wordpress.org
Thu Nov 13 10:46:40 UTC 2014
#5513: Bulk Notifications Management
Reporter: colabsadmin | Owner: boonebgorges
Type: enhancement | Status: reopened
Priority: normal | Milestone: 2.2
Component: Notifications | Version: 2.0
Severity: normal | Resolution:
Keywords: needs-patch |
Comment (by hnla):
>Though I must say I think the cursor: not-allowed is a bit much for my
taste. I'd vote for cursor: default.
:) Thought this would be case, yes I was in two minds about it. Lets use
'default' as value.
>I can't actually find any place where we use either the .pending or the
.disabled class except for in the css as well as one check in the js to
disable stuff with .pending.
This was somewhat my puzzlement here, wasn't sure but had a feeling those
.disabled & .pending were unused, in my time I couldn't recall why we had
these supposed classes in the sheet and sadly when this occurs it does
mean having to spend a bit of time tracking things down. To be honest I
think the .disabled/.pending rulesets are spurious ones and that those
properties are never being applied thus are actually redundant and ought
to be removed, but don't want to guess at that we need to determine
properly, however as they exist and as determining does increase the time
factor in completion somewhat lets leave those added selectors in place we
can always delete the whole ruleset/s if necessary at some later juncture.
> As for the string 'Select Bulk Action' did Boone approve of that or feel
it was unnecessary we'll be led by him on that one and for consistency
with other labels/strings.
>That was how I interpreted it, that he just didn't like the plural...
Reading the comment back Boone was in favour of not over designing on this
and favoured 'Bulk Action'
I stand by the point that the form control is asking for a user action and
it should be saying what action is required 'select blah blah' so as a
compromise lets keep the option string as 'Bulk Action' but the label as
'Select Bulk Action' thus we read the instruction in the label as select
your option anf the option reads as a heading although to be perfectly
honest I don't like options used this way optgroup would be more suitable
or nothing at all and disable the submit based on no checkboxes having
been selected or if multiple checkboxes not selected.
@Boone could we have you take ( and final judgement ) on the label point:
True form label as 'Select Bulk Action', option string as 'Bulk Action' or
both as 'Bulk Action'?
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5513#comment:36>
BuddyPress Trac <http://buddypress.org/>
More information about the buddypress-trac