[buddypress-trac] [BuddyPress Trac] #5981: Activity excerpts show read more link only if excerpt length changed

[buddypress-trac]

#5981: Activity excerpts show read more link only if excerpt length changed
--------------------------+-----------------------------
 Reporter:  hnla          |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Activity      |    Version:
 Severity:  minor         |   Keywords:
--------------------------+-----------------------------
 This is feeling a little confusing, leads on from a forum post where the
 poster wants to show a read more link for all activity entries.

 We show a default set of ellipses unlinked appended to the $text/$excerpt
 and only link through on the activity meta.

 If we force a change to the excerpt length via the filter
 'bp_activity_excerpt_length' in bp_activity_truncate_entry() -  bp-
 activity-filters.php we then have returned a read more link appended after
 the ellipses.

 We do state if original $text doesn't match the return from
 bp_create_excerpt() then append the read more link. A post appears to be
 able to have well over the default 358 characters, is shown as truncated
 so in theory we should have a case where the original $text != $excerpt so
 should be running the read more link.

 What feels confusing is are these in a sense not already excerpts, yes  a
 simple updated avatar entry isn't but a post is and where it is clearly
 truncated thus $excerpt different from $text we only add ellipses until a
 new excerpt length is filtered in whereupon we get a read more link.

 I'm struggling to pin this down but something feels wrong as though we are
 double truncating, not physically but in a logic sense.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5981>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac