[buddypress-trac] [BuddyPress Trac] #5977: Cannot see/activate/delete pending accounts when BuddyPress is activated on a subsite of a multisite installation

[buddypress-trac]

#5977: Cannot see/activate/delete pending accounts when BuddyPress is activated on
a subsite of a multisite installation
-----------------------------------+------------------
 Reporter:  tomdxw                 |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  2.2
Component:  Members                |     Version:  2.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------
Changes (by imath):

 * keywords:   => has-patch 2nd-opinion
 * component:  Administration => Members
 * severity:  major => normal
 * milestone:  Awaiting Review => 2.2


Comment:

 Ok i got it to work!

 But i think we need to discuss with core team the choices i made. I think
 they are consistent. Let's detail them :

 ==== Not multisite config ====
 When a user signs up, he's created with a role on the site. Unless a
 specific constant ( {{{BP_SIGNUPS_SKIP_USER_CREATION}}} is defined. In
 both cases, there's no problem to manage signups and extended profiles.

 ==== Multisite regular configs (BuddyPress is network activated) ====
 When a user signs up, he's created without having a role on any blog. I
 think it's a good thing and we should keep it this way. As BuddyPress is
 network activated, there's no problem to manage signups and extended user
 profiles

 ==== Specific configs : BuddyPress '''is not''' network activated, but
 activated on a site.  ====
 1/ BuddyPress is activated on a subsite of the network
 - managing signups is not possible
 - managing extended profile is only possible for the users having a role
 on the subsite (see #5367)

 2/  BuddyPress is activated on the main site of the network. (tomdxw's
 feedback)
 - it's actually the same case than the previous one except that a menu to
 manage signups shows in the site admin. Clicking on it leads to the result
 tomdxw explains in the description of this ticket.

 Now. A simple fix could be to neutralize the signups management menu for
 case 2/ (i actually thought of it). But i think we have an opportunity to
 fix the situations for these 2 specific configs and also the ticket #5367.

 I'll start by 1/ : the subsite. In this case, it's not possible to
 register a blog from the sub site where BuddyPress is activated. Only user
 accounts can be registered. I Suggest then to use the BuddyPress signup
 process instead of the WPMU one. Registered users will have a role on the
 sub site and it will be possible to manage signups and extended profile
 from there for the user having the {{{'manage_network_options'}}}
 capacity.

 Now 2/ is a bit more complex. Because, you can also register a blog in
 this config. So i suggest to introduce a new function :
 {{{bp_is_network_main_site()}}} to check if the BuddyPress root blog is
 also the main site of the Network. If so, we then create users with role
 on the BuddyPress site so that it's possible to manage extended profile.
 The BuddyPress site is not the primary site if users registered with a
 blog, it is if they simply registered an account. Users having the
 capacity {{{'manage_network_options'}}}  will be able to manage signups.

 I think, although it's a bit different than WordPress Multisite logic
 (creating users without roles), it makes sense for people using such
 particular configs. If they do so, it means : they want BuddyPress to
 manage signups and members extended profile from a site and not from the
 network. So they implicitly agree to create users '''with roles''' on
 their blogs in order to be able to manage them from this site (sub site or
 main site).

 5977.patch is applying the choices i suggest to manage members on the
 network for these 4 configs. What do you think ?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5977#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac