[buddypress-trac] [BuddyPress Trac] #5644: Activity Favorites: alternative management & new features

[buddypress-trac]

#5644: Activity Favorites: alternative management & new features
-----------------------------------+------------------
 Reporter:  imath                  |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  2.1
Component:  Activity               |     Version:  2.0
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------

Comment (by imath):

 In 5644.activity_table.patch, I've tried to take in account the most of
 your feedbacks.


 ==== 1/ The community administrator has the choice ====

 He can choose from the BuddyPress settings wether to leave activated the
 "like" feature for "BuddyPress Favorites" or to use them as "private
 bookmarks"
 [[Image(https://farm6.staticflickr.com/5480/14072997690_1f8043428a_z.jpg)]]
 I guess this will need some better explanation, i'm not satisfied of my
 "Use favorites as a like feature"...


 ==== 2/ Favorites / Likes are specific activities ====

 In this patch i've explored a new way (i think boonebgorges suggested it
 in last dev-chat) of storing the favorites by using the '''activity
 table'''. I've updated the [https://docs.google.com/spreadsheets/d/17bMFm-
 t7MusfKJ1IkkqyJg1CONVYY6PGJ2LI17tbmko/edit?usp=sharing gdoc excel sheet]
 where i now compare the 3 options (activity meta / specific table /
 activity table). Using the activity table seem to be less performant than
 using a specific table but it's still a lot better than using the activity
 meta. Moreover i think my patch can be improve by some object caching at
 key places.
 Thanks to the fact that action strings are generated at run time since
 2.0, whether "likes" or "bookmarks" are on the action of the activity is
 automatically the good one.

 ==== 3/ Favorites as Likes ====
 I've tried to take in account theme backcompat in this patch. So it should
 work in most themes using the BP Theme Compat feature. I've only had an
 issue with the hook {{{bp_activity_entry_meta}}} which is after the
 'delete activity' link. So i moved it up and created the
 {{{bp_activity_after_delete_button_entry_meta}}} hook. Meaning the count
 are staying in buttons (my first patches was using 'interaction navs').
 [[Image(https://farm4.staticflickr.com/3726/14259616425_7468a5099e_z.jpg)]]

 Using the drop down filter 'Likes' will list all activities that have been
 liked by at least one user, the order is the one the parent activity date.
 (As Activity heartbeat i was afraid to change this..). If the
 administrator chooses a 'stream' mode to display comments, the 'like'
 activities will show. The time since link is the one of the parent. As
 stream mode is on in Activity Administration, here's a new screenshot
 illustrating this point :
 [[Image(https://farm6.staticflickr.com/5160/14072957139_fce934debf_z.jpg)]]
 Clicking on "View Activity" will show the "Liked activity".

 A like is only "deletable" from the Activity Administration.

 It's possible to view the likes made by a user on his profile. Nav /
 Directory tab names, strings, slug of the favorites are customizable using
 a filter if the user (for instance me!! doesn't like the "like" term).

 ==== 4/ Favorites as Private bookmarks ====

 If this setting is on, the users who favorited the activity won't show in
 activity stream. The "favorites" user's profile nav will only be viewable
 by the user himself or the admin. Other than that, it behaves the same way
 than before. The administrator will be able to manage users favorites by
 choosing to filter activities on the 'activity_favorite' type
 [[Image(https://farm4.staticflickr.com/3833/14072997740_c325397e7f_z.jpg)]]

 I hope i'm close to your ideas about this feature. Waiting for your new
 feedbacks about it.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5644#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac