[buddypress-trac] [BuddyPress Trac] #5621: Remove buddypress.pot from develop repo

buddypress-trac noreply at wordpress.org
Tue May 6 06:27:48 UTC 2014


#5621: Remove buddypress.pot from develop repo
-------------------------+------------------------------
 Reporter:  netweb       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Core         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+------------------------------

Comment (by netweb):

 Original patch copied over for reference only: `5160-makepot.diff​`

 Replying to DJPaul ticket:5160#comment49
 > 5160-makepot.diff
 > * AFAIK, we haven't turned off potbot yet.
 > * We shouldn't remove the bp-languages folder until that's done, because
 otherwise it might break things.
 > * bp_core_load_buddypress_textdomain() also needs updating.
 > * I don't think generating the POT on every main Grunt task is a good
 idea, because it's not very fast -- plus those changes aren't included in
 this patch?
 > * Switching the CWD from SOURCE to BUILD will cause trunk to not contain
 any POT file which will break
 >  * GlotPress (the build folder is not being added to trunk).
 > * From this patch, I think the idea to update the headers and move the
 POT to the root of src is great.
 >  * Everything else, not so sure yet. :)

 * Agreed, it's not that fast, it was already in the `grunt build-commit`
 and therefore `grunt build-release` tasks, probably not needed in the
 default `grunt build` task.

 * Correct, `/src` will no longer contain a `buddypress.pot`. GlotPress

 * AFAIK GlotPress grabs the `.pot` file from WP's plugin repo
 ([https://plugins.trac.wordpress.org/browser/buddypress/trunk/bp-
 languages/buddypress.pot here]) and not BP's Trac,though I'm not 100% sure
 on this and indeed could be wrong.

 * I personally haven't taken a look at
 `bp_core_load_buddypress_textdomain`



 In 5621.2.diff just the 'pot header' and location are updated.

 - ToDo SVN move and retain history for `buddypress.pot`
  * From `\src\bp-languages\`
  * To `\`
  * Remove the `\src\bp-languages\` folder

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5621#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list