[buddypress-trac] [BuddyPress Trac] #5399: Review metadata functions for irregularities

[buddypress-trac]

#5399: Review metadata functions for irregularities
--------------------------+---------------------------
 Reporter:  boonebgorges  |       Owner:  boonebgorges
     Type:  enhancement   |      Status:  assigned
 Priority:  normal        |   Milestone:  2.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+---------------------------

Comment (by boonebgorges):

 In [changeset:"8132"]:
 {{{
 #!CommitTicketReference repository="" revision="8132"
 In update_meta() functions, return integer value if a new metadata is
 created

 Previously, BP update_meta() functions returned true on a successful
 update
 *or* on the successful creation of new metadata. This is not consistent
 with
 WP's update_metadata(), which on the creation of new metadata acts as a
 wrapper
 for add_metadata(), which in turn returns an integer (the ID of the newly
 created database row).

 This changeset aligns BP's behavior with WP's.

 We don't have any tests that directly address the data type returned by
 these
 functions, but we do have a number of assertTrue assertions to verify the
 setup of various tests. Where appropriate, these have been changed to the
 more
 generous assertNotEmpty.

 See #5399
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5399#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac