[buddypress-trac] [BuddyPress Trac] #5399: Review metadata functions for irregularities

buddypress-trac noreply at wordpress.org
Fri Mar 14 00:50:27 UTC 2014

#5399: Review metadata functions for irregularities
 Reporter:  boonebgorges  |       Owner:  boonebgorges
     Type:  enhancement   |      Status:  assigned
 Priority:  normal        |   Milestone:  2.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |

Comment (by boonebgorges):

 In [changeset:"8132"]:
 #!CommitTicketReference repository="" revision="8132"
 In update_meta() functions, return integer value if a new metadata is

 Previously, BP update_meta() functions returned true on a successful
 *or* on the successful creation of new metadata. This is not consistent
 WP's update_metadata(), which on the creation of new metadata acts as a
 for add_metadata(), which in turn returns an integer (the ID of the newly
 created database row).

 This changeset aligns BP's behavior with WP's.

 We don't have any tests that directly address the data type returned by
 functions, but we do have a number of assertTrue assertions to verify the
 setup of various tests. Where appropriate, these have been changed to the
 generous assertNotEmpty.

 See #5399

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5399#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list