[buddypress-trac] [BuddyPress Trac] #5399: Review metadata functions for irregularities

[buddypress-trac]

#5399: Review metadata functions for irregularities
--------------------------+---------------------------
 Reporter:  boonebgorges  |       Owner:  boonebgorges
     Type:  enhancement   |      Status:  assigned
 Priority:  normal        |   Milestone:  2.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+---------------------------

Comment (by boonebgorges):

 In [changeset:"8131"]:
 {{{
 #!CommitTicketReference repository="" revision="8131"
 Return an empty string from get_meta() functions when no value is found

 BP get_meta() functions have been inconsistent about the type of value
 returned
 when no match is found for the object_id+meta_key combination. In some
 cases,
 we followed WP's get_metadata() and returned an empty string. In others,
 we
 returned false.

 This changeset aligns all of our get_meta() functions with WP in this
 regard,
 returning an empty string when no matching value is found. A boolean false
 is
 still returned when invalid arguments are passed to the functions.

 Relevant unit tests have been updated, including strict assertSame()
 checking
 where appropriate.

 See #5399
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5399#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac