[buddypress-trac] [BuddyPress Trac] #5457: Improvements to friends_get_friend_user_ids()

buddypress-trac noreply at wordpress.org
Wed Mar 12 12:42:58 UTC 2014

#5457: Improvements to friends_get_friend_user_ids()
 Reporter:  r-a-y        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Friends      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |

Comment (by boonebgorges):

 Thanks for doing due diligence on whether the `$assoc_arr` argument is
 used anywhere. However, even though you didn't find any instances of its
 being used in public, I'd wager that someone somewhere is using it for
 some odd reason. Since it's trivial to maintain backward compatibility in
 this case (by shifting `$get_all` to the fourth param slot), let's do it.
 Throw a _deprecated_argument() notice if you'd like.

 The other changes look good to me. Feel free to commit the tests for
 existing functionality before you do the rest of the patch.

 (Side note - in the long run, it'd be nice to migrate these one-offs to
 central query classes. Maybe a `BP_Friend_Query extends BP_User_Query`.
 Caching etc become much easier. But that's an issue for another ticket.)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5457#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list