[buddypress-trac] [BuddyPress Trac] #5779: Ajax & searching in Activities, focusing on Activity Heartbeat feature
buddypress-trac
noreply at wordpress.org
Thu Jul 24 21:09:56 UTC 2014
#5779: Ajax & searching in Activities, focusing on Activity Heartbeat feature
-----------------------------------------------------+------------------
Reporter: imath | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.1
Component: Activity | Version: 2.0
Severity: normal | Resolution:
Keywords: has-patch reporter-feedback 2nd-opinion |
-----------------------------------------------------+------------------
Comment (by SGr33n):
> First, SGr33n, can you confirm that when you say: 'search page', we are
talking about {{{site.url/activity/?s=random}}}. Or is it a plugin that is
creating a specific search feature ?
>
Confirmed
> Second, i'm hesitating about search. As the "Load More" feature doesn't
support search neither, my first idea was to neutralize "load newest" if
we have a {{{?s=random}}} query string: see the {{{ticketnumber
}}}.heartbeat-nosearch.patch. Using this patch, we get rid of the bug.
Seems a good option, also in a semantic view, since that if you are
searching somenthing, means that this something was already published...
maybe this ticket will be updated when BuddyPress will support hashtags.
> So i think we have 2 options :
> - neutralize activity heartbeat if a search is performed >
{{{ticketnumber}}}.heartbeat-nosearch.patch, or
> - support search in activity heartbeat and load more features >
{{{ticketnumber}}}.heartbeat-search.patch + {{{ticketnumber}}}.loadmore-
search.patch
>
> What do you think ?
In my opinion, you can disable it on the search page :)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5779#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list