[buddypress-trac] [BuddyPress Trac] #5779: Ajax & searching in Activities, focusing on Activity Heartbeat feature

[buddypress-trac]

#5779: Ajax & searching in Activities, focusing on Activity Heartbeat feature
-------------------------+-------------------------------------------------
 Reporter:  imath        |      Owner:
     Type:  defect       |     Status:  new
  (bug)                  |  Milestone:  2.1
 Priority:  normal       |    Version:  2.0
Component:  Activity     |   Keywords:  has-patch reporter-feedback 2nd-
 Severity:  normal       |  opinion
-------------------------+-------------------------------------------------
 In a comment to #5505, SGr33n reported a problem with the activity
 Heartbeat feature (load newest) & searching activities. I confirm this
 problem : if you add {{{?s=random}}} it will load all newest activities
 without taking in account the search.

 First, SGr33n, can you confirm that when you say: 'search page', we are
 talking about {{{site.url/activity/?s=random}}}. Or is it a plugin that is
 creating a specific search feature ?

 Second, i'm hesitating about search. As the "Load More" feature doesn't
 support search neither, my first idea was to neutralize "load newest" if
 we have a {{{?s=random}}} query string: see the {{{ticketnumber
 }}}.heartbeat-nosearch.patch. Using this patch, we get rid of the bug.

 Then i thought it's a bit too bad, and i've built {{{ticketnumber
 }}}.heartbeat-search.patch which will load newest activities if they match
 the search_terms.

 Finally, i thought it's a bit more too bad to support search in activity
 heartbeat and not in "load more", so i've build a 3rd patch :
 {{{ticketnumber}}}.loadmore-search.patch.

 So i think we have 2 options :
 - neutralize activity heartbeat if a search is performed > {{{ticketnumber
 }}}.heartbeat-nosearch.patch, or
 - support search in activity heartbeat and load more features >
 {{{ticketnumber}}}.heartbeat-search.patch + {{{ticketnumber}}}.loadmore-
 search.patch

 What do you think ?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5779>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac