[buddypress-trac] [BuddyPress Trac] #6040: Friendship activity missing

[buddypress-trac]

#6040: Friendship activity missing
------------------------------------+-----------------------
 Reporter:  dontdream               |       Owner:  imath
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.2
Component:  Friends                 |     Version:  1.1
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------

Comment (by imath):

 Thanks r-a-y & boonebgorges for your feedbacks

 I agree with r-a-y about :
 > But, I think separating the hardcoded scopes away from
 `BP_Activity_Activity::get_scope_query_sql()` makes sense and allows
 developers to make adjustments to them as well if needed.

 So in 6040.3.patch, i've copied the filters r-a-y created for the
 different scopes without the changes in {{{src/bp-friends/bp-friends-
 activity.php}}}. In this file, i've only kept an adapted version of
 r-a-y's {{{bp_friends_filter_activity_just_me_scope()}}} function. I've
 also included the upgrade routine and the unittests.

 This means, we are only creating one public activity when a friendship is
 created having the type {{{'friendship_created'}}}. Since i've followed
 DJPaul's advice in #6055, only having {{{'friendship_created'}}} type is
 making sure activity will be deleted in case a friendship has been
 removed.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6040#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac