[buddypress-trac] [BuddyPress Trac] #5768: Pagination link error for search results in Messages > Inbox

[buddypress-trac]

#5768: Pagination link error for search results in Messages > Inbox
------------------------------+------------------
 Reporter:  mercime           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.1
Component:  Messaging         |     Version:  1.6
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------

Comment (by r-a-y):

 > One possible solution is to stop using $_REQUEST, and instead check
 $_GET and $_POST separately, giving precedence to what's in $_POST. I
 think that would do it?

 Actually, whatever we pass as 'search_terms' to the loop gets precedence
 so it doesn't matter if we leave the `$_REQUEST` in place.

 My main issue is does anyone have any qualms about removing these lines
 from bp-legacy's JS in general?

 {{{
 if ( bp_get_querystring('s') && !search_terms ) {
         search_terms = bp_get_querystring('s');
 }
 }}}

 `03.patch` removes these lines and offers better pagination support when
 JS is disabled for all our main paginated loops.  I'm probably missing a
 few secondary loops though.

 From my browser testing on the members and groups directories (both with
 JS on and off), I don't see any problems.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5768#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac