[buddypress-trac] [BuddyPress Trac] #5768: Pagination link error for search results in Messages > Inbox

[buddypress-trac]

#5768: Pagination link error for search results in Messages > Inbox
------------------------------+------------------
 Reporter:  mercime           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.1
Component:  Messaging         |     Version:  1.6
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------

Comment (by boonebgorges):

 Replying to [comment:9 r-a-y]:
 > Any reason why we fallback on the querystring for search terms in the JS
 to begin with?  Shouldn't the template loops handle this instead?

 I think it's happening here:
 https://buddypress.trac.wordpress.org/browser/tags/2.0.2/bp-messages/bp-
 messages-template.php#L168 (line 200). Moving this logic into the template
 won't make a difference because the AJAX pagination loads the entire
 template content, so members/single/messages/messages-loop.php will get
 loaded up in its entirety during an AJAX call, in which case we run into
 the same issue.

 One possible solution is to stop using `$_REQUEST`, and instead check
 `$_GET` and `$_POST` separately, giving precedence to what's in `$_POST`.
 I think that would do it?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5768#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac