[buddypress-trac] [BuddyPress Trac] #5807: 'new_member' activity type should not be a xProfile activity type

[buddypress-trac]

#5807: 'new_member' activity type should not be a xProfile activity type
-----------------------------------+------------------
 Reporter:  imath                  |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  2.1
Component:  Activity               |     Version:  1.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------

Comment (by imath):

 Replying to [comment:5 DJPaul]:
 > (e.g. it doesn't fix any problem)?

 Thanks DJPaul for your feedback, it looks like my english is not very
 clear in the description of this ticket (really sorry for that).

 The 2 patches are actually fixing the same issue in 2 different ways. I'll
 try to explain myself in a better way using screenshots to describe the
 issue. Let's consider this configuration :
 - Registration open to new members
 - BuddyPress xProfile component '''deactivated'''

 A user activates his account, an empty activity is generated.

 [[Image(https://farm4.staticflickr.com/3923/14708933610_23eba62e1c_z.jpg)]]
 Back end ([https://www.flickr.com/photos/im4th/14708933610/sizes/o/ full
 size])

 It's more "weird" on the front end

 [[Image(https://farm6.staticflickr.com/5596/14895596185_2155512c3f_z.jpg)]]
 Front end ([https://www.flickr.com/photos/im4th/14895596185/sizes/o/ full
 size])

 About the patches :
 - 5807.disable_new_member.patch will fix the issue by checking id xProfile
 is active before adding a 'new_member' activity and will add the
 'new_member' activities to the {{{NOT IN}}} sql part of
 {{{BP_Activity_Activity::get()}}}. No empty activity will show anymore.
 - 5807.move_new_member.patch will fix the issue by associating the
 'new_member' activity type to the Members component. Conceptually, I
 personaly think it's the best component to associate this type with, as
 nothing in the name of the type or in the action performed by the user is
 related to his profile.
 - I'm going to add a 3rd patch: 5807.at_the_very_least.patch which
 basically does not create an activity if xProfile is inactive. Applying it
 will avoid new empty activities but old ones will show.

 It may be an edge case, i guess, as it has never been reported. But i
 might not be the only one who doesn't activate xprofile and it disturbs me
 a bit to create some content relative to an inactive component..

 Anyway, in the meantime I'm simply using this :
 {{{remove_action( 'bp_core_activated_user', 'bp_core_new_user_activity'
 );}}} from bp-custom.php

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5807#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac