[buddypress-trac] [BuddyPress Trac] #5807: 'new_member' activity type should not be a xProfile activity type
buddypress-trac
noreply at wordpress.org
Tue Aug 12 12:25:50 UTC 2014
#5807: 'new_member' activity type should not be a xProfile activity type
-----------------------------------+------------------
Reporter: imath | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.1
Component: Activity | Version: 1.1
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+------------------
Comment (by boonebgorges):
> other than changing the type of these profile field entries to tidy it
up, and moving the code from one component to another, this doesn't do
anything? (e.g. it doesn't fix any problem)?
Incorrect. The problem is this: `bp_core_new_user_activity()` (in the
Members component) creates an `xprofile` activity item. If this happens
when the xprofile component is disabled, the proper activity action
callback won't exist (`bp_xprofile_format_activity_action_new_member()`).
So an empty string gets saved in the database, and an empty activity item
is displayed when the page is rendered.
The proper fix is to move the whole works into the Members component, but
this is more than I think we should do for 2.1. imath's minimal fix will
at least keep the blank items from appearing in these cases.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5807#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list