[buddypress-trac] [BuddyPress Trac] #5553: BP 2.0 upgrade routine improperly deletes existing user roles if activation_key usermeta is present

[buddypress-trac]

#5553: BP 2.0 upgrade routine improperly deletes existing user roles if
activation_key usermeta is present
-----------------------------------+--------------------
 Reporter:  boonebgorges           |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  highest                |   Milestone:  2.0.1
Component:  Core                   |     Version:  2.0
 Severity:  critical               |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+--------------------

Comment (by boonebgorges):

 > Well, only if the constant BP_SIGNUPS_SKIP_USER_CREATION is defined,

 Ah, OK. I was looking at the current code and forgetting we used to do
 this: https://buddypress.trac.wordpress.org/browser/tags/1.9.2/bp-members
 /bp-members-functions.php#L1320

 My method is safer, but it does introduce more overhead during the upgrade
 process. Have a test and see what you think.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5553#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac