[buddypress-trac] [BuddyPress] #4879: add_theme_support( 'buddypress' ) should not load buddypress-functions.php

[buddypress-trac]

#4879: add_theme_support( 'buddypress' ) should not load buddypress-functions.php
-------------------------------------+------------------
 Reporter:  modemlooper              |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  1.9
Component:  Backwards Compatability  |     Version:  1.7
 Severity:  major                    |  Resolution:
 Keywords:  needs-testing has-patch  |
-------------------------------------+------------------

Comment (by r-a-y):

 > If theme compat is disabled, what's the difference if the template stack
 is registered?

 I believe I remember reading in another ticket that it might be
 advantageous for bp-legacy templates to "leak" through.  If you remove the
 `bp_deregister_template_stack()` line, bp-legacy templates will indeed be
 used as a fallback if the templates don't exist in the parent / child
 theme.  I think we should deregister it as it makes logistical sense.
 Just wanted a second opinion!

 (As I was looking for this ticket, Boone actually mentioned the
 `bp_load_theme_functions()` approach in ticket:4846#comment:4.)

 I'm fine with your function naming, Boone!  Was kind of contemplating the
 same thing as I was writing the code.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4879#comment:15>
BuddyPress <http://buddypress.org/>
BuddyPress