[buddypress-trac] [BuddyPress] #4879: add_theme_support( 'buddypress' ) should not load buddypress-functions.php

[buddypress-trac]

#4879: add_theme_support( 'buddypress' ) should not load buddypress-functions.php
-------------------------------------+------------------
 Reporter:  modemlooper              |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  1.9
Component:  Backwards Compatability  |     Version:  1.7
 Severity:  major                    |  Resolution:
 Keywords:  needs-testing has-patch  |
-------------------------------------+------------------

Comment (by boonebgorges):

 Good find, r-a-y.

 > The only thing I'm worried about in the patch is deregistering the
 default theme compat template stack. Could use some dev feedback on this.

 I'm not sure the point of doing this. If theme compat is disabled, what's
 the difference if the template stack is registered?

 Function naming is non-ideal, IMO. `bp_enable_theme_compat()` sounds like
 a verb ("hey BP, enable theme compat!") but it's actually a check. Maybe
 better: `bp_is_theme_compat_enabled()`? The other function,
 `bp_set_enable_theme_compat()`, also makes it sound as if theme compat is
 being enabled, when really it's *detecting whether* it should be enabled.
 Maybe better: `bp_set_theme_compat()`?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4879#comment:14>
BuddyPress <http://buddypress.org/>
BuddyPress