[buddypress-trac] [BuddyPress] #5097: Activity meta data not deleted for the comments of an activity when the activity is deleted (bloating the meta table with orphans)

buddypress-trac noreply at wordpress.org
Sun Oct 13 02:36:05 UTC 2013


#5097: Activity meta data not deleted for the comments of an activity when the
activity is deleted (bloating the meta table with orphans)
------------------------------+---------------------
 Reporter:  dtc7240           |       Owner:  r-a-y
     Type:  defect (bug)      |      Status:  closed
 Priority:  high              |   Milestone:  1.9
Component:  Activity          |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------
Changes (by r-a-y):

 * owner:   => r-a-y
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7422"]:
 {{{
 #!CommitTicketReference repository="" revision="7422"
 Delete activity comment meta when deleting parent activity items.

 Previously, when deleting parent activity items, BP would delete the
 related activity comments, but not the activity comment metadata.

 To solve this, activity comments are now queried and removed in the
 main BP_Activity_Activity::delete() method and the activity comment
 IDs are now properly passed to the delete_activity_meta_entries()
 method.

 Commit also includes a unit test for this issue.

 Hat-tip boonebgorges for feedback.

 Fixes #5097.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5097#comment:7>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list