[buddypress-trac] [BuddyPress] #5185: BP Signup - spaces in username issue

[buddypress-trac]

#5185: BP Signup - spaces in username issue
-------------------------------------+------------------
 Reporter:  hnla                     |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  1.9
Component:  Core                     |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------
Changes (by boonebgorges):

 * keywords:   => has-patch needs-testing
 * milestone:  Awaiting Review => 1.9


Comment:

 Thanks for the ticket, hnla. This behavior in BP trackes back to #471
 r1061.

 My suggestion is that we remove this behavior altogether, and replace it
 with a registration warning. This will fix the issue described in #471 for
 all cases where users go through normal registration, ie the vast majority
 of cases. The big change will be that plugins etc will be able to create
 new users programatically where the user_login contains spaces. But IMO
 this is an edge case; and in any case, the current behavior - of swapping
 the space with a hyphen without any warning or feedback - is at least as
 bad as the original problem described in #471.

 There is a larger question of why we have to enforce this at all. If WP
 allows for spaces in user_login, then maybe we should too. As per #471,
 this will cause problems in some places in BP, but this is what
 user_nicename is for; yet there will be complications with
 username_compatibility_mode, etc etc etc. So, I'm going to suggest that,
 for the time being, we keep the behavior the same as it is now - no spaces
 in usernames - but simply change how that's enforced.

 Patch attached.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5185#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress