[buddypress-trac] [BuddyPress] #5185: BP Signup - spaces in username issue

[buddypress-trac]

#5185: BP Signup - spaces in username issue
--------------------------------------------+---------------------------
 Reporter:  hnla                            |       Owner:  boonebgorges
     Type:  enhancement                     |      Status:  closed
 Priority:  normal                          |   Milestone:  1.9
Component:  Core                            |     Version:
 Severity:  normal                          |  Resolution:  fixed
 Keywords:  has-patch needs-testing commit  |
--------------------------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7570"]:
 {{{
 #!CommitTicketReference repository="" revision="7570"
 Remove BuddyPress's restriction spaces in user_login

 BuddyPress has historically enforced a no-spaces rule on user_login during
 user registration. Originally this was rooted in WPMU's own peculiar
 character
 restrictions, and when the MU requirement was dropped, the same
 restrictions
 were carried over to WordPress Single.

 However, these restrictions have caused various problems. BP enforced the
 "no
 spaces" rule during registration by simply swapping out spaces with
 hyphens and
 not telling users. This caused immense confusion. Moreover, the
 restriction
 caused problems when bypassing BP's native user registration, as when
 integrating with an external authentication service; these external
 usernames
 *can* sometimes have spaces, and certain areas of BuddyPress were not
 equipped
 to deal with them.

 This changeset removes the no-spaces restriction from BuddyPress, and
 hands
 off user_login validation to WordPress Multisite when possible (meaning
 that on
 MS, spaces will still not be allowed during native registration). It also
 makes the necessary adjustments throughout BuddyPress to ensure that
 spaces
 in user_login will not break related functionality. On a normal setup, BP
 (and
 WP) only use user_login for authentication, but several changes were
 necessary
 to account for "username compatibility mode", where the user_login is
 displayed
 publicly:

 - Refactor the way that activity @-mentions work in username compatibility
   mode. We now have functions for converting user IDs to "mentionname"
 (and vice
   versa) which will produce @-mention-safe versions of user_nicename or
   user_login, as appropriate.
 - Use proper URL encoding when building and parsing URLs that contain
 usernames
   when compatibility mode is enabled.
 - Fix private messaging autocomplete to work with spaces.

 See #4622

 Fixes #5185
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5185#comment:15>
BuddyPress <http://buddypress.org/>
BuddyPress