[buddypress-trac] [BuddyPress] #4846: Theme compat is overaggressive in loading its files, especially JS

[buddypress-trac]

#4846: Theme compat is overaggressive in loading its files, especially JS
-----------------------------------+------------------
 Reporter:  boonebgorges           |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  high                   |   Milestone:  1.7
Component:  Theme                  |     Version:  1.7
 Severity:  critical               |  Resolution:
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+------------------

Comment (by imath):

 Replying to [comment:5 boonebgorges]:
 > we might consider a sanity check like 4846.01.patch

 Hi Boone,
 I think it's a good idea, i've ran some test with a premium theme with the
 2 patches. It's working for the first one if in the functions.php of the
 theme the "add_theme_support( 'buddypress' );" is added.

 But for 4846.01.patch it looks like dtheme-ajax-js is not enqueued yet. So
 when debug is set to true in my wp-config.php, the warning message is not
 displayed.

 If i edit the functions.php in order to enqueue the script a bit earlier,
 for example :
 add_action( 'wp_enqueue_scripts', 'bp_dtheme_enqueue_scripts', 9 );
 then the message is showing

 If i change the priority of the bp_enqueue_script hook to 11 in bp-core-
 actions.php, like this
 add_action( 'wp_enqueue_scripts',      'bp_enqueue_scripts',        11
 );
 then the message is showing

 Problem is : if the priority is changed in bp-core-actions, does it cause
 any regressions ? I will keep on my tests with the 2 other themes we've
 discussed about and keep you updated.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4846#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress