[buddypress-trac] [BuddyPress] #4846: Theme compat is overaggressive in loading its files, especially JS

[buddypress-trac]

#4846: Theme compat is overaggressive in loading its files, especially JS
-----------------------------------+------------------
 Reporter:  boonebgorges           |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  high                   |   Milestone:  1.7
Component:  Theme                  |     Version:  1.7
 Severity:  critical               |  Resolution:
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+------------------

Comment (by boonebgorges):

 Quick follow-up. In addition to 4846.patch, we might consider a sanity
 check like 4846.01.patch (basically, my suggestion 2 above). In short:
 before enqueuing bp-legacy JS, check to see if bp-default's js has already
 been enqueued. If so, throw an error message and bail. (We can't safely
 dequeue dtheme-ajax-js because we will break dependencies.) Note that this
 patch will only work if you hook the enqueue_scripts() method later than
 `after_setup_theme:10`; see my comment 4 for explanation.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4846#comment:5>
BuddyPress <http://buddypress.org/>
BuddyPress