[buddypress-trac] [BuddyPress] #4802: Site notices to all users and bp theme compat

[buddypress-trac]

#4802: Site notices to all users and bp theme compat
--------------------------+------------------
 Reporter:  imath         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  1.7
Component:  Core          |     Version:  1.7
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+------------------

Comment (by imath):

 >>he will never receive an email when the admin sends a notice to all
 users
 >Is this a bug? Are they *supposed* to receive an email? If so, we should
 fix the bug rather than removing the setting (assuming it's a regression).
 Well i've just checked in 1.6.4, and i don't think not sending emails is a
 bug : in the bp-message-screens.php the function
 messages_screen_notification_settings() checks for
 'notification_messages_new_notice' usermeta and this usermeta is stored in
 bp-settings-action.php with the function
 bp_settings_action_notifications(). But it's never used to eventually send
 an email to the user. I guess, if the host limits the number of emails
 that can be sent at the same time, and the community has a lot of users,
 it can be problematic to send a lot of emails at the same time..
 Instead, when an admin adds a new notice, it is inserted in
 $bp->messages->table_name_notices and another usermeta seems to store an
 array containing the ids of the notices he has closed thanks to
 bp_dtheme_ajax_close_notice() in order to stop displaying it. The usermeta
 key is 'closed_notices'.

 >I think that using a sidebar widget is more elegant
 I agree, but, i think it's then necessary to check if this widget is
 activated before displaying the checkbox to the admin in the compose
 screen of the bp message component.
 On the other hand, i realized that the diff i posted won't display the
 notice at 100%. For instance if for some reason the admin is not using at
 least 1 widget, then the notice is not displayed..

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4802#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress