[buddypress-trac] [BuddyPress] #5300: Notifications from inactive components are rendered on the Notifications panel

buddypress-trac noreply at wordpress.org
Tue Dec 17 14:45:48 UTC 2013


#5300: Notifications from inactive components are rendered on the Notifications
panel
-----------------------------------+--------------------
 Reporter:  boonebgorges           |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  1.9.1
Component:  Notifications          |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+--------------------

Comment (by boonebgorges):

 I'm not suggesting that 'active' be *temporary*, but that it be
 *shorthand* for 'component_name' = [active components]. (Maybe the way
 that 'active' is implemented deep down would be temporary, but that
 wouldn't be visible to end users or devs.)

 In any case, I do share your inclination not to introduce new params where
 possible, but in this case, the syntax seemed funny to me. Passing a null
 value for 'component_name' should, at a glance, return *no* results at
 all, but we're proposing that it return results for active components.
 Does this seem misleading? I might be overthinking it.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5300#comment:7>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list