[buddypress-trac] [BuddyPress] #4265: WP 3.4/BP1.5.6 – issue with quotes on SWA

[buddypress-trac at lists.automattic.com]

#4265: WP 3.4/BP1.5.6 – issue with quotes on SWA
-------------------------------+------------------------------
 Reporter:  chouf1             |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Core               |     Version:  1.5.6
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |
-------------------------------+------------------------------
Changes (by chouf1):

 * version:   => 1.5.6


Comment:

 Hello Boone and DJPaul,

 i actually use bp 1.5.6 standart and WP 3.4.1 french edition.
 The problem sits in WP, i guess because BP looks fine now.

 Before latest update, I changed the WP 3.3.2 translation for curly quotes
 from 8220 to « (alt+0171) to have something correct.

 This is what you can see under the link i give in my first post here.

 Since update to 3.4.1 (with use of the original FR translation) quotes
 seems to be correctly outputed. That said, this FR translation missed the
 closing curly cote in the 3.3.2 version)

 When posting on a forum, the quotes are OK for now. But inserting code
 with tags or bakcsticks in a forum post or an answer is completly weird.
 Same thing in blog post and comments.

 To reproduce, try with this exemple with php and html who looks awfull:

 {{{
 Posting some code inside backsticks
 `if(bp_use_wp_admin_bar())
     return bpln_get_notifications_for_wpadminbar();
         $html= '<li id="bp-adminbar-notifications-menu"><a href="' .
 $bp->loggedin_user->domain . '">';
         $html.=__( 'Notifications', 'buddypress' );

         if ( $notifications = bp_core_get_notifications_for_user(
 $bp->loggedin_user->id ) )
             $html.="<span>".count( $notifications )."</span>";`

 Posting code using pre tag
 <pre>if(bp_use_wp_admin_bar())
     return bpln_get_notifications_for_wpadminbar();
         $html= '<li id="bp-adminbar-notifications-menu"><a href="' .
 $bp->loggedin_user->domain . '">';
         $html.=__( 'Notifications', 'buddypress' );

         if ( $notifications = bp_core_get_notifications_for_user(
 $bp->loggedin_user->id ) )
             $html.="<span>".count( $notifications )."</span>";</pre>

 Posting code using code tag
 <code>if(bp_use_wp_admin_bar())
     return bpln_get_notifications_for_wpadminbar();
         $html= '<li id="bp-adminbar-notifications-menu"><a href="' .
 $bp->loggedin_user->domain . '">';
         $html.=__( 'Notifications', 'buddypress' );

         if ( $notifications = bp_core_get_notifications_for_user(
 $bp->loggedin_user->id ) )
             $html.="<span>".count( $notifications )."</span>";</code>
 }}}

 You can see it here in a blog post
 http://bp-fr.net/2012/07/probleme-de-quotes/
 And here in a forum topic
 http://bp-fr.net/groups/utilisation-configuration-optimisation-de-
 buddypress/forum/topic/probleme-de-quotes-bis-repetita/

 Output changes a little bit if i remove those filters via functions.php

 {{{
 remove_filter( 'bp_get_the_topic_latest_post_excerpt',
 'bp_forums_filter_kses', 1 );
 remove_filter( 'bp_get_the_topic_post_content', 'bp_forums_filter_kses', 1
 );
 }}}

 Even if this ticket looks as a WP problem, it seems to me that there is
 somwhere a double filtering by calling a WP filter and adding a BP filter
 (or more). ?!!!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4265#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress