[buddypress-trac] [BuddyPress] #4403: Fatal Error After Upgrading to BuddyPress 1.6

[buddypress-trac at lists.automattic.com]

#4403: Fatal Error After Upgrading to BuddyPress 1.6
-------------------------------+--------------------
 Reporter:  steve7777          |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  1.6.1
Component:  Core               |     Version:  1.6
 Severity:  major              |  Resolution:
 Keywords:  reporter-feedback  |
-------------------------------+--------------------
Changes (by boonebgorges):

 * severity:  blocker => major
 * milestone:  Awaiting Review => 1.6.1


Comment:

 It'd be extremely helpful to see a debug_backtrace(), if anyone can make
 it happen.

 I had a look at where `bp_is_user()` is called throughout BP. The only
 function that could possibly be called in a context where it'd cause this
 kind of error is in `bp_core_new_subnav_item()`. My guess is that the
 problem can be traced to
 http://buddypress.trac.wordpress.org/changeset/4600, where the
 `bp_is_user()` check was added.

 This, in enough, isn't enough to cause fatal errors. It has to be combined
 with a plugin that is calling bp_core_new_subnav_item() in the right way -
 which is to say, too early. Again, this is a guess, but it's possible that
 you were both using plugins that do this thing that plugins used to do in
 the BP 1.1 era:

 {{{
 function foo() {
     bp_core_new_subnav_item( $args );
 }
 add_action( 'wp', 'foo', 2 );
 add_action( 'admin_menu', 'foo', 2 );
 }}}

 The problem would be the admin_menu call, which might be early enough to
 load before the members component is loaded.

 Can you guys give a list of the BP-dependent plugins you're running on
 your installations? Then we can look through and see whether any are doing
 what I suspect they're doing. If my theory is right, we can do a fix for
 1.6.1 that will bail out of bp_core_new_subnav_item() when used too early
 (there's no need to run it in the admin anyway).

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4403#comment:7>
BuddyPress <http://buddypress.org/>
BuddyPress