[buddypress-trac] [BuddyPress] #4393: Delete button in Favorites page should not be their

[buddypress-trac at lists.automattic.com]

#4393: Delete button in Favorites page should not be their
--------------------------+------------------------------
 Reporter:  kumo99        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Activity      |     Version:  1.6-rc
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+------------------------------
Changes (by r-a-y):

 * component:  Core => Activity


Comment:

 I like the idea of using an additional activity meta entry.  So a definite
 "yes" to that.

 In my proposal, I overvalued how much the favorite system is used, which
 is why my rationale was from the perspective of efficiency vs. real-time
 calculation.

 I would be okay with moving the favorite activity exists check if we can
 minimize the overhead on the lookup.

 Maybe with a direct DB query like:

 {{{
 SELECT id FROM {$bp->activity->table_name} WHERE id IN (
 $comma_delimited_favorite_ids );"
 }}}

 instead of using bp_activity_get() due to its joining on the usermeta and
 xprofile tables?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4393#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress