[buddypress-trac] [BuddyPress] #4393: Delete button in Favorites page should not be their

[buddypress-trac at lists.automattic.com]

#4393: Delete button in Favorites page should not be their
--------------------------+------------------------------
 Reporter:  kumo99        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Core          |     Version:  1.6-rc
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+------------------------------

Comment (by boonebgorges):

 rachelbaker and I spent some time today working on a patch that takes a
 slightly different tack. In addition to storing an array of favorited
 activities with each user, the proposal is to store an array of user ids
 who have favorited a given activity item (in the activitymeta table). That
 way, when an item is deleted, we can loop through and remove the favorite
 for each of these members.

 We thought we'd go this direction, instead of doing something like what
 you've suggested, because it checking those activity items on login would
 be both too much (there's a lot of unnecessary overhead in many cases) and
 not enough (since a user may remain logged in for a long time, and it
 still leaves the count incorrect for long periods). That said, we could
 combine the two a bit: each time a favorite is added or deleted, we could
 pull up a list of the user's favorites, and make sure that they all exist.
 This would help with backward compatibility, as well as making sure that
 the mirrored data stays in sync. What do you think, r-a-y?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4393#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress