[buddypress-trac] [BuddyPress] #3381: xProfile subnav links enhancement

[buddypress-trac at lists.automattic.com]

#3381: xProfile subnav links enhancement
-------------------------------------------------+-------------------------
 Reporter:  slaFFik                              |       Owner:  slaFFik
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  XProfile                             |  Review
 Severity:  normal                               |     Version:  1.3
 Keywords:  dev-feedback has-patch needs-        |  Resolution:
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by boonebgorges):

 slaFFik - Thanks for the explanation. It's a little bit clearer now. It
 seems to me that you are requesting two totally separate things: (1) the
 "subnav_exists" function for easier templating, and (2) for profile subnav
 items to be added with user_has_access => bp_is_my_profile(). Is that
 correct?

 I think I understand why (1) would be useful.

 As for (2), I agree that it would be better to hide/show these links using
 user_has_access (at the level of the nav construction) rather than at the
 template level. Paul points out that this was problematic in the past (in
 reality, we would need to do something like
 {{{'user_has_access' => bp_is_my_profile() || is_super_admin())}}}

 But IMO it would be better to wait to fix this across all of BP until we
 have integrated WP roles. That way, we can do something like
 {{{'user_has_access' => bp_is_my_profile() || current_user_can(
 'bp_edit_others_profiles' )}}}

 So - if I'm understanding this correctly, I don't have a problem adding a
 function like what slaFFik is suggesting in (1), but the issue in (2)
 should be left as-is for now.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3381#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress