[buddypress-trac] [BuddyPress] #3381: xProfile subnav links enhancement

[buddypress-trac at lists.automattic.com]

#3381: xProfile subnav links enhancement
-------------------------------------------------+-------------------------
 Reporter:  slaFFik                              |       Owner:  slaFFik
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  XProfile                             |  Review
 Severity:  normal                               |     Version:  1.3
 Keywords:  dev-feedback has-patch needs-        |  Resolution:
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by slaFFik):

 * cc: slava.abakumov@… (added)
 * keywords:  dev-feedback has-patch => dev-feedback has-patch needs-testing


Comment:

 Boone, I'm adding lots of menus under Profile nav. Some of them are for
 public view, some of them are for owner adding/editing actions.

 I would like to use bp_core_new_nav_item() - and that's all. Just give
 different access via user_has_access - and no need to use lots of hooks
 and change default files (or coping and modifying them into the child
 themes).

 bp_is_component_subnav_exists (or similar) will give the idea whether the
 main menu (Profile, or Docs or Groups or Pages - in my BP Groups Extras -
 or whatever) has childs or subpages. Useful for displaying the subnav when
 we have smth to display.

 'users_has_access' => bp_is_my_profile() will close from displaying
 private subpages. As for me we will have much more flexibility. I have
 tested own patch and didn't find problems. The only not very nice but
 tolerable issue is that under Profile menu when you are browsing
 somebody's profile there will be only 1 submenu called Public, while in
 your code it's hidden ( "if bp_is_my_profile()" check hide it).

 Boone, did I answer your question?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3381#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress