[buddypress-trac] [BuddyPress] #3821: Unbind selectors from tokens in jQuery
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Sat Dec 17 10:42:42 UTC 2011
#3821: Unbind selectors from tokens in jQuery
----------------------------------+------------------
Reporter: hnla | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 1.6
Component: Theme | Version:
Severity: normal | Resolution:
Keywords: needs-testing commit |
----------------------------------+------------------
Comment (by hnla):
Yep this is the about the only 'edge case' of concern that these tokens
are used elsewhere.
The term 'rogue' is apt though as I would say this would be an unwise and
shortsighted thing to do definitely not something I would do if I were
using global.js in it's default state in fact to re-use an establish class
or id in this manner is just asking for trouble.
Question is, and as asked earlier by Boone, how much do we care about this
possible edge case breaking child theme? the simple notion of breaking a
child theme is obviously something we would never want to knowingly do
but in this instance I am going to say that given they(the rogue dev)
ought really not to have done this that we don't accept this as a reason
not to go ahead; the benefits to doing this are vast and also I fear if we
can't do this then if child themes or bp-default require the present js
functionality they will not be able to move to a fully realised HTML5
layout.
I'm still concerned though that there isn't a more genuine use case that
would cause, or present, problems not thought of yet.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3821#comment:7>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list