[buddypress-trac] [BuddyPress] #2024: bp_core_override_adminbar_css() should no longer be used

Sun Feb 21 08:01:09 UTC 2010

#2024: bp_core_override_adminbar_css() should no longer be used
------------------------+---------------------------------------------------
Reporter:  TobiasBg     |       Owner:       
    Type:  enhancement  |      Status:  new  
Priority:  trivial      |   Milestone:  1.2.1
Keywords:  has-patch    |  
------------------------+---------------------------------------------------
Changes (by cnorris23):

  * priority:  major => trivial

Comment:

 Deprecated functions are either removed completely and added to the
 BuddyPress Backwards Compatibility plugin, or have their guts replaced
 with a call to the new/replacement/alternative function. For instance:

 {{{
 function bp_core_override_adminbar_css() {
      newer_awesomer_function();
 }
 }}}

 Given that this function is not used elsewhere, removal is the most likely
 course of action.> This function is not needed and has drawbacks:
 > - In all cases, where this function would print its output (CSS
 commands), the corresponding HTML is not even there (see
 bp_core_admin_bar() in bp-core/bp-core-adminbar.php).

 Given that bp_core_override_adminbar_css() is not used elsewhere, and is
 handled in bp_core_admin_bar(),removal is the most likely course of
 action.

 > - The function inserts a HTML <style> element into the <body> of the
 page, thus making the page invalid HTML/XHTML.

 The validation issues could have been fixed by hooking into {{{wp_head}}},
 instead of {{{wp_footer}}}.

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2024#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress