[buddypress-trac] [BuddyPress] #2024: bp_core_override_adminbar_css() should no longer be used

Sat Feb 20 17:38:17 UTC 2010

#2024: bp_core_override_adminbar_css() should no longer be used
------------------------+---------------------------------------------------
Reporter:  TobiasBg     |       Owner:       
    Type:  enhancement  |      Status:  new  
Priority:  major        |   Milestone:  1.2.1
Keywords:  has-patch    |  
------------------------+---------------------------------------------------
 While investigation #2023, I found the function
 "bp_core_override_adminbar_css()" in bp-core/bp-core-cssjs.php.

 This function is not needed and has drawbacks:
 - In all cases, where this function would print its output (CSS commands),
 the corresponding HTML is not even there (see bp_core_admin_bar() in bp-
 core/bp-core-adminbar.php).
 - The function inserts a HTML <style> element into the <body> of the page,
 thus making the page invalid HTML/XHTML.

 Therefore, this function is not necessary and should be deprecated.

 The attached patch removes the add_action call that loads the function,
 and adds a @deprecated comment (as I did not find another common practice
 of deprecating functions, like a bp-deprecated.php).

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2024>
BuddyPress <http://buddypress.org/>
BuddyPress